Fix deprecated calls to thread.isAlive() with thread.is_alive().

plexinc / plex-for-kodi

Offical Plex for Kodi add-on releases.

GNU General Public License v2.0

251 stars 124 forks source link

Fix deprecated calls to thread.isAlive() with thread.is_alive(). #350

Closed mliudev closed 2 years ago

mliudev commented 3 years ago

This call was deprecated in python 3.9. See: https://bugs.python.org/issue37804

GHI (If applicable): #349

Description:

Fixes #349.

This fix seems to work on

Arch 5.11.7-arch1-1 Kodi 19.0 script.plex v0.3.3

I'm using Arch's kodi-standalone service and the kodi-gbm package.

Checklist:

[x] I have based this PR against the develop branch

mliudev commented 2 years ago

I'm not longer using this plugin so I'm closing it. Feel free to co-opt the code if still necessary.

springjools commented 2 years ago

Thanks for making the fix and out of curiosity: what are you using instead? I have this exact same problem.

mliudev commented 2 years ago

Thanks for making the fix and out of curiosity: what are you using instead? I have this exact same problem.

Sorry for the late reply @springjools I used https://github.com/croneter/PlexKodiConnect for a bit but the UI started to lag for large libraries. I've since switched to just using the desktop Plex app. Kodi doesn't support all the shaders for retroarch that I wanted either so I decided to just go with a full on desktop instead of Kodi.

ruuk commented 2 years ago

Long delayed reply, but I merged your commit here: https://github.com/plexinc/plex-for-kodi/commit/984a572248fe5c1af7451dc3d36a3e7bd82c6dd9

Thanks for the PR!