plexinc / plex-for-kodi

Offical Plex for Kodi add-on releases.
GNU General Public License v2.0
251 stars 123 forks source link

Proper error msg when transcode failed #352

Open Fneufneu opened 3 years ago

Fneufneu commented 3 years ago

Description:

Kodi just show the fanart background when transcoding failed and i think it would be better if it's display a correct msg.

important error: Not enough CPU for conversion of this item. Neither direct play nor conversion is available

log:

2021-05-14 14:43:26.336 T:16104   ERROR <general>: EXCEPTION Thrown (PythonToCppException) : -->Python callback/script returned the following error<--
                                                    - NOTE: IGNORING THIS CAN LEAD TO MEMORY LEAKS!
                                                   Error Type: <class 'AttributeError'>
                                                   Error Contents: 'str' object has no attribute 'decode'
                                                   Traceback (most recent call last):
                                                     File "C:\Users\Fneufneu\AppData\Roaming\Kodi\addons\script.plex\lib\player.py", line 745, in _playVideo
                                                       self.playerObject = self.playerObject.getServerDecision()
                                                     File "C:\Users\Fneufneu\AppData\Local\Packages\XBMCFoundation.Kodi_4n2hpmxwrvr6p\LocalCache\Roaming\Kodi\addons\script.plex\lib\_included_packages\plexnet\plexplayer.py", line 216, in getServerDecision
                                                       return decision.getDecision()
                                                     File "C:\Users\Fneufneu\AppData\Local\Packages\XBMCFoundation.Kodi_4n2hpmxwrvr6p\LocalCache\Roaming\Kodi\addons\script.plex\lib\_included_packages\plexnet\serverdecision.py", line 65, in getDecision
                                                       raise DecisionFailure(code, reason)
                                                   plexnet.serverdecision.DecisionFailure: (2000, 'Not enough CPU for conversion of this item. Neither direct play nor conversion is available.')

                                                   During handling of the above exception, another exception occurred:

                                                   Traceback (most recent call last):
                                                     File "C:\Users\Fneufneu\AppData\Roaming\Kodi\addons\script.plex\lib\windows\kodigui.py", line 105, in onInit
                                                       self.onFirstInit()
                                                     File "C:\Users\Fneufneu\AppData\Roaming\Kodi\addons\script.plex\lib\windows\videoplayer.py", line 91, in onFirstInit
                                                       self.play(resume=self.resume)
                                                     File "C:\Users\Fneufneu\AppData\Roaming\Kodi\addons\script.plex\lib\windows\videoplayer.py", line 234, in play
                                                       player.PLAYER.playVideoPlaylist(self.playQueue, resume=self.resume, session_id=id(self), handler=handler)
                                                     File "C:\Users\Fneufneu\AppData\Roaming\Kodi\addons\script.plex\lib\player.py", line 806, in playVideoPlaylist
                                                       self._playVideo(resume and self.video.viewOffset.asInt() or 0, seeking=handler and handler.SEEK_PLAYLIST or 0, force_update=True)
                                                     File "C:\Users\Fneufneu\AppData\Roaming\Kodi\addons\script.plex\lib\player.py", line 747, in _playVideo
                                                       util.showNotification(e.reason, header=util.T(32448, 'Playback Failed!'))
                                                     File "C:\Users\Fneufneu\AppData\Roaming\Kodi\addons\script.plex\lib\util.py", line 179, in showNotification
                                                       icon_path = icon_path or xbmc.translatePath(ADDON.getAddonInfo('icon')).decode('utf-8')
                                                   AttributeError: 'str' object has no attribute 'decode'
                                                   -->End of Python script error report<--

Details:

Checklist