plexinc / plex-media-player

Next generation Plex Desktop/Embedded Client
GNU General Public License v2.0
1.17k stars 170 forks source link

HW decoding on macOS introduces macroblock artifacts #1077

Open selfsimilar opened 2 years ago

selfsimilar commented 2 years ago

When 'Use Hardware Decoding' is active in Settings > Plex for Mac > Player, macroblocks or CTUs become much more visible, especially in very noisy parts of images like background. This creates a 'screendoor'-type effect where horizontal and vertical macroblock boundaries look like a regular grid over the image. The effect is more subtle in some scenes than others, but is more visible in video than in still frames, and especially when along borders from background to foreground for example when the foreground is moving slightly (like a person talking). I'll try to find a small video to attach that best illustrates the effect.

Test environment

PMS Version: 1.25.2.5319 PMP Version: Version: Plex for Mac version 1.44.0.2981-e2d72ac2 Platform: macOS v 12.3.1 - MacBook Pro (16", 2021) - Chip Apple M1 Max

Steps to reproduce

  1. Enable 'Use Hardware Decoding'

Current behavior

Screen Shot 2022-05-09 at 1 08 08 PM

Expected behavior

Screen Shot 2022-05-09 at 1 08 34 PM

selfsimilar commented 2 years ago

Very noticeable in mkvs with the following settings: Codec H264 Bitrate 10163 kbps Bit Depth 8 Chroma Location topleft Chroma Subsampling 4:2:0 Coded Height 816 Coded Width 1920 Color Primaries bt709 Color Range tv Color Space bt709 Color Trc bt709 Frame Rate 23.976 fps Height 802 Level 4.0 Profile high Ref Frames 5 Scan Type progressive Width 1918 Display Title 1080p (H.264) Extended Display Title 1080p (H.264)

selfsimilar commented 2 years ago

Vertical artifacts very apparent in the suit in foreground on right half of the screen.

HW Decoding on

Screen Shot 2022-05-09 at 1 51 08 PM (2)

HW Decoding off

Screen Shot 2022-05-09 at 1 52 31 PM (2) Severed.mkv.zip