ghost
commented
8 years ago Can you point out where exactly it fails? I'm not sure if I understand this report.
Closed finalwar closed 6 years ago
ghost
commented
8 years ago Can you point out where exactly it fails? I'm not sure if I understand this report.
JSMSC
commented
8 years ago Shure, it's the last line in the first log: `ERROR: "/Volumes/SPRCapitanEXT/myname EXT/ProgrammeEXT/Xcode-beta.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/objdump: '/Users/myname /dev/plex/pmp-v29-06-16/build/output/Plex Media Player.app/Contents/Resources/updater': No such file or directory.\nfatal error: /Volumes/SPRCapitanEXT/myname EXT/ProgrammeEXT/Xcode-beta.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/otool: internal objdump command failed\n"``
If i don't copy the "updater" file from a prebuild binary I can't compile the.app bundle.
ghost
commented
8 years ago Right, this is a non-open sourced component. (Not sure if we could open source it, but currently it isn't.) Since it's also useless for 3rd party builds, we should probably just make it optional.
JSMSC
commented
8 years ago It's already in the AppleConfiguration.cmake file
find_library(FOUNDATION Foundation)
find_library(APPKIT AppKit)
find_library(IOKIT IOKit)
find_library(COCOA Cocoa)
find_Library(CARBON Carbon)
find_library(SECURITY Security)
set(OS_LIBS ${FOUNDATION} ${APPKIT} ${IOKIT} ${COCOA} ${SECURITY} ${CARBON} spmediakeytap hidremote)
set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS}")
set(CMAKE_C_FLAGS "${CMAKE_C_FLAGS} -mmacosx-version-min=10.9 -fno-omit-frame-pointer")
set(WARNINGS "-Wall")
**set(HAVE_UPDATER 1)
find_program(UPDATER_PATH updater HINTS ${CMAKE_FIND_ROOT_PATH}/update_installer/ NO_DEFAULT_PATH)
if(${UPDATER_PATH} MATCHES "UPDATER_PATH-NOTFOUND")
set(HAVE_UPDATER 0)
message(STATUS "will build without the updater")
endif(${UPDATER_PATH} MATCHES "UPDATER_PATH-NOTFOUND")**
set(INSTALL_BIN_DIR .)
set(INSTALL_RESOURCE_DIR Resources)but it seems that it doesn't matter, so i would appreciate it if would be made optional otherwise.
tru
commented
8 years ago I think this can easily be solved in CompleteBundleOSX.cmake.in the line that adds updater as a binary just needs to be guarded inside if(@HAVE_UPDATER@).. If you have the time to test this I am happy to accept a patch for it.
LongChair
commented
6 years ago @finalwar : is this still relevant or can we close this ?
LongChair
commented
6 years ago pretty sure this should not be a problem now. Closing it for clarity, feel free to reopen if needed.
I build PmP nearly every day from Source on OSX 10.11.6beta3 In addition I have a full featured Qt 5.7.0 installation on my mac. In the last days i got problems with buildings, because ninja won't find the updater which was never included in other Source builds as it is intended by a cmake file when building from source. If I copy the updater from a downloaded build and place it where ninja wants it, PmP builds the bundle. Installing with Xcode instead of ninja gives no problems. Any idea? I append the install logs so you can take a look on it. Current PmP version number and build (running - when updater is copied) relates to 1.1.3.dev-d2b10478
Build without the copied updater
`
appended install log with copied updater from other release
`