plexinc / plex-media-player

Next generation Plex Desktop/Embedded Client
GNU General Public License v2.0
1.16k stars 170 forks source link

Change default webMode to "tv" #948

Closed mseeley closed 4 years ago

mseeley commented 4 years ago

This PR changes the default layout to "tv", from Desktop. This change has already been made in our v3 preview builds.

Expected behavior

Previous to this change the default webMode was "desktop". On first run PMP creates plexmediaplayer.conf using the configuration defined in settings_description.json. With this in mind any PMP installations which have been run at least once will experience no change to the layout displayed on last run.

Existing installations, once updated to a version with this change, will change their webMode when one of the following happens:

Fresh installations not covered above will default webMode to "desktop".

Steps to test

mseeley commented 4 years ago

@pcalves I've tried to trigger a test build of this branch in https://github.com/plexinc/plex-media-player/tree/dist-matt-tv-default-webMode. The force may not be strong enough with me.

pcalves commented 4 years ago

Triggered a build by hand in Jenkins: https://nightlies.plex.tv/plexmediaplayer/dist-matt-tv-default-webMode/2.53.0.1060-cff90758/

mseeley commented 4 years ago

Thanks @pcalves!