search

plexinc / plex-media-player

Next generation Plex Desktop/Embedded Client
GNU General Public License v2.0
1.16k stars 170 forks source link

Update plexmediaplayer.desktop #950

Closed photoenix closed 4 years ago

photoenix commented 4 years ago

Default behavior should be to auto save the last used layout. --fullscreen --tv breaks that functionality and forces the fullscreen TV layout on all users every start.

Plex-CLA-1.0-signed-off-by: Manuel Rusch manuel.rusch@gmail.com

photoenix commented 4 years ago

Hi @mseeley, sorry about that! This is my first time on git. :)

mseeley commented 4 years ago

Hi @photoenix no worries. I think it's awesome you're here!

Thanks for updating the PR title. We can land this PR once the commit message is also updated. This looks like the ticket: https://help.github.com/en/github/committing-changes-to-your-project/changing-a-commit-message

photoenix commented 4 years ago

I can't figure out how to change the commit message for the life of me. The changed message displays in Terminal but not on here. I followed a bunch of YT tutorials but I simply can't figure it out. I made a second commit with the additional layout. Does that work? Otherwise shall I just make a new PR and close this one? I'm sorry for being such a noob :/

mseeley commented 4 years ago

@photoenix there are a couple ways to do it. Here's a way I tested just now:

  1. git reset HEAD~2
    • This will rewind your branch to 2 commits behind its latest commit. Changes from those two commits are still available in your branch.
  2. git commit -a
    • Commit all changed files.
  3. Paste in your commit message (below)
    • Git should open a new editor.
    • Your branch now includes 1 new commit.
  4. git push -f
    • Push your local branch and overwrite the history of the remote branch.
Update plexmediaplayer.desktop

- Default behavior should be to auto save the last used layout.
  --fullscreen --tv breaks that functionality and forces the fullscreen TV layout on all users every start.
- Added windowed TV option.

Plex-CLA-1.0-signed-off-by: Manuel Rusch manuel.rusch@gmail.com
photoenix commented 4 years ago

@mseeley that didn't work either, but I found my error by chance: I was pushing it to master the whole time. I had to set my default branch to patch-1, that did the trick. Thanks for all the help and being so patient :)