search

plexinc / plex-media-player

Next generation Plex Desktop/Embedded Client
GNU General Public License v2.0
1.16k stars 170 forks source link

PMP - Windows 10 - Always stuck in full screen view #951

Closed GlitterHorn closed 4 years ago

GlitterHorn commented 4 years ago

Test environment

PMS Version: 1.18.9.2571 PMP Version: 1.6.3.1009-57cf57c8 Platform: Windows 10

Steps to reproduce

  1. Launch PMP
  2. Try to exit full screen view (F11 or Alt+Enter)
  3. PMP will not exit full screen. The window flashes for a moment as if it tried to restore to windowed, but then jumps back to full screen.

Current behavior

  1. Always maximized

Expected behavior

  1. PMP should exit full screen.

Addendum: I can't find the Plex config file mentioned in this 2017 forum thread. There's also this 2018 forum thread, so it sounds like this bug has been around for awhile.

mseeley commented 4 years ago

Hi @ClairelyClaire is this on an integrated or external monitor? I'll test both ways regardless.

Am I correct that the app was exited when fullscreen, then restored fullscreen at next launch, and now refuses to exit fullscreen?

GlitterHorn commented 4 years ago

Yes - exiting and relaunching still ends up stuck in full screen.

This is on a desktop with external monitors.

mseeley commented 4 years ago

@ClairelyClaire, a fix for this will be released in 1.9.0. Thanks for reporting. :)

GlitterHorn commented 4 years ago

Still broken in 1.9.0.1188-c009e512.

That said it seems the desktop version of the UWP is working again, so at least I have Plex without forced full screen. (PS please don't break the UWP app intentionally, it's so much better than the desktop app)

mseeley commented 4 years ago

@ClairelyClaire Curious, thansk for mentioning. What are the values of the [ui] section of your plex.ini (%LOCALAPPDATA%\Plex\plex.ini)?

Pre 1.9 we would save the window's dimensions when maximizing or entering fullscreen. Now we will only save window dimensions when not in either of those states.

Exiting and relaunching while in fullscreen should relaunch the app in fullscreen. Although now you should be able to exit fullscreen. The window should take the size of the last windowed size. If that last size was recorded when maximized/fullscreen in 1.8 then that'll still be the size we use. Nothing stops a user from having a !maximized window that is the size of the screen.