search

plexsystems / sinker

A tool to sync images from one container registry to another
MIT License
609 stars 53 forks source link

Sinker docker image? #29

Closed OmegaVVeapon closed 4 years ago

OmegaVVeapon commented 4 years ago

Hello!

I started playing with Sinker today and it's great, definitely what we need for our use case.

However, I wanted to use it as part of our CI pipelines to keep project images synced to our internal registries and I can't find a Sinker Docker image anywhere... before I rolled out my own I wanted to ask, does it already exist somewhere?

jpreese commented 4 years ago

One does not currently exist, but I do think there should be one.

OmegaVVeapon commented 4 years ago

Great, in that case, I'll try to submit a PR to get that done on this repo (reading on on this now.)

Would that be alright? Or would you rather take on that task yourself?

jpreese commented 4 years ago

Nope, would be greatly appreciated! If you don't want to deal with the pipeline piece (because secrets will be involved), just the Dockerfile itself would be a huge help.

OmegaVVeapon commented 4 years ago

Done.

@jpreese Please let me know if there's any changes needed in the PR discussion.

eik3 commented 4 years ago

Thanks for the Dockerfile! sinker works great and I'd like to start using it from Kubernetes.

If this issue is about an official sinker docker image in a public registry, I'm confused why it's closed - I looked around in a couple of registries and didn't find one. There's also no workflow yet that builds and pushes sinker. Is this still being worked on?

jpreese commented 4 years ago

@eik3 sorry about that! The Dockerfile was made, but I never did the last couple of polishes I wanted to give it and push it up to the registry. I'll do that today.

jpreese commented 4 years ago

@eik3 sorry for the delay on this. v0.14.0 has been released and the corresponding Docker image has been pushed to DockerHub. The image (and future images) can be found at https://hub.docker.com/repository/docker/plexsystems/sinker

eik3 commented 4 years ago

Thanks @jpreese! 

$ docker run --rm -it plexsystems/sinker --version
sinker version v0.14.0

:tada: