search

plexsystems / vscode-protolint

A protobuf linter for visual studio code
MIT License
52 stars 14 forks source link

Updated activation event so linter triggers on files ending with .pro… #1

Closed luke142367 closed 4 years ago

luke142367 commented 4 years ago

…to rather than when the proto language is set

CLAassistant commented 4 years ago

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.

lely seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

jpreese commented 4 years ago

Now that protolint supports proto2, the extension should indeed be updated to trigger on more than proto3 extensions.

Did you intend for the PR to be closed @luke142367 ?

luke142367 commented 4 years ago

Yes I do, this was created by accident, sorry about that

jpreese commented 4 years ago

No worries! The change looks good so if you'd like to open it in the future, let me know! Otherwise I'll fix this when I get a moment.

Thanks for finding this!