Closed silenceisgolden closed 3 years ago
Looking through the vscode api for getWorkspaceFolder and workspaceFolders, this looks perfect to me @silenceisgolden.
I agree, the whole file changing could be related to tabs vs. spaces. I didn't even realize that value was set incorrectly. This has been updated. Feel free to merge latest into this branch.
I wouldn't worry too much about the testing aspect. It's a very minor change, the extension itself is pretty small, and the core logic is based around parsing errors which already has tests for it.
If you want to update the PR such that only the single line is modified, I'll go ahead and merge it in and cut a new release with this fix.
Much appreciated! 💯
@jpreese Updated, and commits squashed.
Turns out on Mac's trying to preserve CRLF, users need to set git config --global core.autocrlf true
on their local.
Oof, good catch! Thanks for fixing this. I'll add it into the next release.
There may be some issues with this PR:
.editorconfig
that should be changed such asindent_style = 2
->indent_style = tab
?vscode.TextDocument
in order to test the method. I am happy to add tests though if you can point me in the right direction on mocking.