Closed ziishaned closed 4 years ago
Thanks for the submission @ziishaned. I'll take a look at this today
Could you also provide a use case for this? What problem are you running into?
protolint
should be finding the .protolint.yaml
for you, even if the .proto
is nested. Unless your use case has the protolint config elsewhere?
Just checking in @ziishaned :)
@jpreese sorry for the late response. Currently this extension expects that you have a protolint configuration in the root. But in my case the configuration was in the project directory because of that the linting was not working. Also I think its a good idea to use project configuration if it avaliable otherwise fall back to global configration(Users root directory)
I think we need to do some more changes regarding above usecase e.g. give the priority to the project directory configuration if its avaliable otherwise use global configuration.
No worries, just wanted to get a clearer idea of what the problem was. If you've got an example folder structure where the extension doesn't pick up on the lint config, that'd be awesome.
The PR in its current form would still need some modifications, and seems a bit stale.
All committers have signed the CLA.