plexsystems / vscode-protolint

A protobuf linter for visual studio code
MIT License
54 stars 14 forks source link

.protolint.yaml can't affect vscode-protolint #9

Closed IS-Martin closed 4 years ago

IS-Martin commented 4 years ago

As the title and my version info are as follows

My proto

image

My .protolint.yaml

image

My file structure

- root
  - definition
    - myproto.proto
  - .protolint.yaml

and also tried

- root
  - definition
    - myproto.proto
    - .protolint.yaml

Just wondering why the .protolint.yaml didn't affect vscode linting as expected.

jpreese commented 4 years ago

Thanks for submitting the issue @MartinChangCF! We'll definitely take a look at this.

In the meantime, have you tested your configuration with just protolint on the command line? I'd like to rule out a protolint specific issue.

IS-Martin commented 4 years ago

Sorry for the late reply @jpreese

I tried the protolint command

protolint  ./

and with --config_dir_path

protolint  --config_dir_path=./ ./protoc

they both work properly.

jpreese commented 4 years ago

Thanks. I did some investigation on this end as well and am definitely seeing some odd behavior. It does work if the .protolint.yaml file is in the same directory as the proto definitions.

I'll do some more digging and see what we can do to get this resolved.

jpreese commented 4 years ago

@MartinChangCF this should now be resolved in v0.3.0 -- could you confirm at your earliest convenience? Thanks again for reaching out 👍

IS-Martin commented 4 years ago

@jpreese Thanks for your updates! It works now 👍

jpreese commented 4 years ago

Awesome, glad to hear.