search

plexus / chestnut

Application template for Clojure + ClojureScript web apps
Eclipse Public License 1.0
1.32k stars 99 forks source link

HTTP Server logs to System/out #218

Closed abhi18av closed 7 years ago

abhi18av commented 7 years ago

Hi @plexus

This template is an absolute life saver 👍

Could you please tell me how to disable logging?

screen shot 2017-08-18 at 17 35 43

For my use-case it's more of a distraction. Also, is there a way to switch to a nashorn/ rhino repl instead of the browser repl as far as clojurescript is concerned?

plexus commented 7 years ago

Hi!

I don't immediately have an answer to those questions, maybe you're looking for the mailing list?

On Aug 18, 2017 14:08, "Abhinav Sharma" notifications@github.com wrote:

Hi @plexus https://github.com/plexus

This template is an absolute life saver 👍

Could you please tell me how to disable logging?

For my use-case it's more of a distraction. Also, is there a way to switch to a nashorn/ rhino repl instead of the browser repl as far as clojurescript is concerned?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/plexus/chestnut/issues/218, or mute the thread https://github.com/notifications/unsubscribe-auth/AAB91MPpRt8WiUILCTR2eBIGtfRzyN3Yks5sZX68gaJpZM4O7eCr .

featheredtoast commented 7 years ago

There was a recent change here with removing onelog, which in the past, set up all http logging to fall under log/server.log

You'll now need to explicitly include onelog to get back logging config. Include this in your project dependencies: [onelog "0.5.0"]

See relevant commit here: https://github.com/plexus/chestnut/commit/7a3658efdfcccfadc01ecf4c08f6ba75a8743aa2

@plexus I know we're trying to remove a conflict with different log versions, but should we have a log4j/onelog implementation included by default?

plexus commented 7 years ago

I know we're trying to remove a conflict with different log versions, but should we have a log4j/onelog implementation included by default?

No idea... I'd have to dig into this. Happy to take your advice on this.

featheredtoast commented 7 years ago

I'd recommend adding the onelog dependency by default, and if a user is doing a fancier logging setup, they'll have full control over changing it, since the referenced commit.

plexus commented 7 years ago

Sounds good! Sorry I'm a bit swamped with other stuff at the moment... anyone wants to cook up a PR?

featheredtoast commented 7 years ago

No worries, I'll create one later today

On Aug 18, 2017 7:11 AM, "Arne Brasseur" notifications@github.com wrote:

Sounds good! Sorry I'm a bit swamped with other stuff at the moment... anyone wants to cook up a PR?

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/plexus/chestnut/issues/218#issuecomment-323364518, or mute the thread https://github.com/notifications/unsubscribe-auth/ABQuJo4MO_v4mb9vTIcVPD4ZgG0c2ohNks5sZZujgaJpZM4O7eCr .

plexus commented 7 years ago

Sweet!

On 18 August 2017 at 16:56, Jeff Wong notifications@github.com wrote:

No worries, I'll create one later today

On Aug 18, 2017 7:11 AM, "Arne Brasseur" notifications@github.com wrote:

Sounds good! Sorry I'm a bit swamped with other stuff at the moment... anyone wants to cook up a PR?

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/plexus/chestnut/issues/218#issuecomment-323364518, or mute the thread https://github.com/notifications/unsubscribe-auth/ABQuJo4MO_ v4mb9vTIcVPD4ZgG0c2ohNks5sZZujgaJpZM4O7eCr

.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/plexus/chestnut/issues/218#issuecomment-323376271, or mute the thread https://github.com/notifications/unsubscribe-auth/AAB91CeT_JbSH_XwUCQRTLeK6asblyIRks5sZaYdgaJpZM4O7eCr .

-- I create beautiful Clojure and ClojureScript screencasts @ https://lambdaisland.com

abhi18av commented 7 years ago

Hey, @plexus and @featheredtoast thanks for being so responsive on this :)

However, adding [onelog "0.5.0"] raises this warning message. I tried removing the slf4j-nop and slf4j-log4j12 folders as mentioned in website http://www.slf4j.org/codes.html#multiple_bindings but it just re-downloads that anyway.

SLF4J: Class path contains multiple SLF4J bindings.
SLF4J: Found binding in [jar:file:/Users/eklavya/.m2/repository/org/slf4j/slf4j-nop/1.6.2/slf4j-nop-1.6.2.jar!/org/slf4j/impl/StaticLoggerBinder.class]
SLF4J: Found binding in [jar:file:/Users/eklavya/.m2/repository/org/slf4j/slf4j-log4j12/1.7.7/slf4j-log4j12-1.7.7.jar!/org/slf4j/impl/StaticLoggerBinder.class]
SLF4J: See http://www.slf4j.org/codes.html#multiple_bindings for an explanation.
abhi18av commented 7 years ago

The following exclusion resolves this 

 [onelog "0.5.0" :exclusions [org.slf4j/slf4j-log4j12]]

I'll be closing this now as my original issue is perfectly solved.

However, could you please tell me how could I hook into the nashorn/ rhino repl using the template instead of the browser?

featheredtoast commented 7 years ago

I honestly don't know enough about running cljs over nashorn/node to speak to that, sorry. This template makes some firm assumptions using clj for server-side, and cljs for client-side. If you're interested in cljs server-side, this would best be asked in #clojurescript on the clojurians slack.

https://clojurescript.org/community/resources