plexus / chestnut

Application template for Clojure + ClojureScript web apps
Eclipse Public License 1.0
1.32k stars 99 forks source link

Figwheel version might need to be updated to latest #234

Closed loganpowell closed 6 years ago

loganpowell commented 6 years ago

In reference to an issue with clearing the browser cache between projects I got on the #figwheel channel and found that older versions have this problem that I experienced where I used chestnut on two adjacent projects and the old project was loading in the browser.

featheredtoast commented 6 years ago

Hey, thanks for the report - you can get around this by using the +edge flag so it automatically comes with the latest libraries.

@plexus this is the second time recently in which something broke with an older dependency (The bidi PR). I'd still be in favor of bumping the base versions of dependencies when a bug affects Chestnut like that.

loganpowell commented 6 years ago

Thank you @featheredtoast! Will do.

plexus commented 6 years ago

@featheredtoast I'm all for updating our dependencies, just been busy with other stuff. There's code in the repo to generate an up-to-date dependency list. If someone would like to prep a PR than I'll make sure it makes its way to Clojars.

loganpowell commented 6 years ago

Sorry, I've been on a project and doing this on the side, so just getting back to trying this, but got this:

Unrecognized option: +edge . Should be one of +http-kit +site-middleware +less +sass +reagent +vanilla +garden +rum +om-next +re-frame +code-of-conduct +coc +no-poll
plexus commented 6 years ago

ugh yeah we really need to get a new version out, seems the version on clojars doesnt support edge yet. Meanwhile have a look at the README for how to use the snapshot version. i think +edge should work with that. On May 3, 2018 7:44 PM, "Logan Powell" notifications@github.com wrote:

Sorry, I've been on a project and doing this on the side, so just getting back to trying this, but got this:

Unrecognized option: +edge . Should be one of +http-kit +site-middleware +less +sass +reagent +vanilla +garden +rum +om-next +re-frame +code-of-conduct +coc +no-poll

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/plexus/chestnut/issues/234#issuecomment-386378361, or mute the thread https://github.com/notifications/unsubscribe-auth/AAB91PWBd6atL0huvnNOrrqU8e22fDh2ks5tu0HhgaJpZM4TjjiX .

plexus commented 6 years ago

Said new version is out now, all dependencies have been upgraded to latest, so a regular lein new chestnut should do the trick. Thanks for reporting this!

loganpowell commented 6 years ago

Sweet!! Thank you so much 👍