search

plexus / unrepl.el

Mozilla Public License 2.0
16 stars 2 forks source link

Replace edn.el with clj-parse #9

Open plexus opened 7 years ago

plexus commented 7 years ago

Currently incoming unrepl messages are parsed with edn.el. This is problematic because edn.el tries to parse them to Emacs data structures, which isn't able to represent all of Clojure's data structures.

This requires more work on clj-parse though.

To illustrate some of the issues

unrepl.replG__8=> (fn [])
#unrepl/object [(TAGGED1337 unrepl.java/class unrepl.replG__8$eval368$fn__369) "0x67d4a54c" "unrepl.replG__8$eval368$fn__369@67d4a54c" {:bean {(TAGGED1337 unrepl/... {:get (unrepl.replG__8/fetch :G__372)}) (TAGGED1337 unrepl/... nil)}}]
unrepl.replG__8=> #{}
(edn-set nil)
unrepl.replG__8=> false
nil
unrepl.replG__8=>
bbatsov commented 7 years ago

The other problem is that edn.el depends on a totally unmaintained library available only on EmacsWiki...

This requires more work on clj-parse though.

What's this? Some new Emacs Lisp library?

plexus commented 7 years ago

https://github.com/lambdaisland/clj-parse/

On Jul 7, 2017 9:41 AM, "Bozhidar Batsov" notifications@github.com wrote:

The other problem is that edn.el depends on a totally unmaintained library available only on EmacsWiki...

This requires more work on clj-parse though.

What's this? Some new Emacs Lisp library?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/plexus/unrepl.el/issues/9#issuecomment-313611137, or mute the thread https://github.com/notifications/unsubscribe-auth/AAB91HdSJ8-H4B16NlHouHdnV5-1v7Ksks5sLeEZgaJpZM4OLjRT .