search

plexus / yaks

Ruby library for building hypermedia APIs
http://rubygems.org/gems/yaks
MIT License
236 stars 26 forks source link

handle Proc in if options #116

Closed hallgren closed 8 years ago

hallgren commented 8 years ago

The current spec I wrote did not check if the if option were a Proc.

plexus commented 8 years ago

don´t know that I'm doing but seams to work..

:smile: is that referring to the use of Resolve?

Jest aside, please pay some more attention to commit messages. I know I don't always do this right either, but have a look at the history and you will find many good examples. The typical format is a single line of less than 70 or 80 characters, then a blank line, then a full explanation, manually line wrapped at 80 chars.

A small tip when working on pull requests: I don't get any notifications when you push new code. If you're done making changes (e.g. you've addressed the review comments), it's a good idea to leave a comment here briefly summarising what you changed.

That said I think code wise this is good enough to go in. Maybe you can squash the commits together into one and give it a more elaborate description? I can put out a new release afterwards.

hallgren commented 8 years ago

Thank for the tips, commiting code on a fever seams like a bad idea.. Looks like i didn´t knew what I were doing...

I try to rap this one up the coming week.