search

plfs / plfs-core

LANL no longer develops PLFS. Feel free to fork and develop as you wish.
41 stars 36 forks source link

Make the flat file and small file mode optional #325

Closed zhang-jingwang closed 11 years ago

zhang-jingwang commented 11 years ago

So that the user can disable them when needed, with: cmake -DUSE_FLATFILE=OFF ./ or cmake -DUSE_SMALLFILE=OFF ./

thewacokid commented 11 years ago

My only real concern with this is what should a user expect if trying to parse a PLFSRC file with flat-file or small-file mount points. If either are disabled at build-time, any PLFSRC containing them will cause PLFS to be unusable until the user creates his/her own PLFSRC file without any incompatible mounts.

I would assume any system installations of PLFS would include these modes but I think we need to think about what we're presenting to the user in the case of them being disabled.

brettkettering commented 11 years ago

This seems more complex than just a build option. The disabling build option could, I suppose, set some environment element that tells the PLFSRC parser to ignore anything with a disabled workload. So, even if it's in the file the output of plfs_check_config would only show the mount point workloads that are not disabled.

Brett

From: David Bonnie notifications@github.com<mailto:notifications@github.com> Reply-To: plfs/plfs-core reply@reply.github.com<mailto:reply@reply.github.com> Date: Tuesday, November 5, 2013 8:33 AM To: plfs/plfs-core plfs-core@noreply.github.com<mailto:plfs-core@noreply.github.com> Subject: Re: [plfs-core] Make the flat file and small file mode optional (#325)

My only real concern with this is what should a user expect if trying to parse a PLFSRC file with flat-file or small-file mount points. If either are disabled at build-time, any PLFSRC containing them will cause PLFS to be unusable until the user creates his/her own PLFSRC file without any incompatible mounts.

I would assume any system installations of PLFS would include these modes but I think we need to think about what we're presenting to the user in the case of them being disabled.

— Reply to this email directly or view it on GitHubhttps://github.com/plfs/plfs-core/pull/325#issuecomment-27782217.

zhang-jingwang commented 11 years ago

OK. Got it. Thank you for the information.

johnbent commented 11 years ago

Can't we only disable the code but keep the parser working so unsupported mounts in plfsrc are silently ignored?

On Nov 5, 2013, at 8:33 AM, David Bonnie notifications@github.com wrote:

My only real concern with this is what should a user expect if trying to parse a PLFSRC file with flat-file or small-file mount points. If either are disabled at build-time, any PLFSRC containing them will cause PLFS to be unusable until the user creates his/her own PLFSRC file without any incompatible mounts.

I would assume any system installations of PLFS would include these modes but I think we need to think about what we're presenting to the user in the case of them being disabled.

— Reply to this email directly or view it on GitHub.