plgd-dev / go-coap

Implementation of CoAP Server & Client in Go
https://coap.technology
Apache License 2.0
448 stars 116 forks source link

fix loss of order of messages #426

Closed jkralik closed 1 year ago

jkralik commented 1 year ago

using goPool causes loss of order of messages. For example coap notfications comes in order, but goroutines from gopool are executed underministic.

codecov-commenter commented 1 year ago

Codecov Report

Merging #426 (8068e59) into master (01faa43) will decrease coverage by 0.03%. The diff coverage is 74.65%.

@@            Coverage Diff             @@
##           master     #426      +/-   ##
==========================================
- Coverage   71.46%   71.44%   -0.03%     
==========================================
  Files          69       70       +1     
  Lines        5289     5484     +195     
==========================================
+ Hits         3780     3918     +138     
- Misses       1122     1171      +49     
- Partials      387      395       +8     
Impacted Files Coverage Δ
dtls/server/config.go 71.42% <ø> (+7.14%) :arrow_up:
options/config/common.go 100.00% <ø> (ø)
udp/server/config.go 71.42% <ø> (ø)
options/commonOptions.go 43.39% <60.86%> (+1.33%) :arrow_up:
tcp/client/conn.go 69.72% <68.23%> (-3.32%) :arrow_down:
udp/client/conn.go 69.47% <71.61%> (-3.23%) :arrow_down:
message/pool/message.go 76.11% <84.21%> (+0.48%) :arrow_up:
dtls/server/server.go 76.47% <100.00%> (-0.57%) :arrow_down:
net/client/receivedMessageReader.go 100.00% <100.00%> (ø)
tcp/client/session.go 80.14% <100.00%> (+6.18%) :arrow_up:
... and 16 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

sonarcloud[bot] commented 1 year ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 4 Code Smells

75.9% 75.9% Coverage
0.1% 0.1% Duplication