plgd-dev / go-coap

Implementation of CoAP Server & Client in Go
https://coap.technology
Apache License 2.0
446 stars 116 forks source link

Fix processing of observe notifications with ETags #471

Closed Danielius1922 closed 1 year ago

Danielius1922 commented 1 year ago

Upon the commencement of the observation, the client has the ability to include ETAGs options within the GET request utilizing the observe option. Subsequently, on the server side, a Valid status code can be returned if any of the provided ETAGs are found to be a match.

codecov-commenter commented 1 year ago

Codecov Report

Merging #471 (5d8baf6) into master (c1d1847) will increase coverage by 0.08%. The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master     #471      +/-   ##
==========================================
+ Coverage   72.36%   72.44%   +0.08%     
==========================================
  Files          70       70              
  Lines        5474     5437      -37     
==========================================
- Hits         3961     3939      -22     
+ Misses       1116     1105      -11     
+ Partials      397      393       -4     
Files Changed Coverage Δ
net/blockwise/blockwise.go 69.70% <ø> (+0.11%) :arrow_up:
net/observation/handler.go 81.75% <0.00%> (ø)

... and 5 files with indirect coverage changes

sonarcloud[bot] commented 1 year ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication