search

plgd-dev / go-coap

Implementation of CoAP Server & Client in Go
https://coap.technology
Apache License 2.0
447 stars 116 forks source link

Update to use pion/transport/v3 #480

Closed hasheddan closed 1 year ago

hasheddan commented 1 year ago

Updates to the newly released pion/transport/v3, which matches the dependency of the pion/dtls version used in this repository.

See https://github.com/pion/transport/issues/264 for more information.

Closes #478

Danielius1922 commented 1 year ago

@jkralik It doesn't seem we will be able to merge this until we drop support for go1.18 in plgd/device and plgd/hub, I've tried updating plgd/device to this version of go-coap and it failed compilation with go1.18 (https://github.com/plgd-dev/device/actions/runs/6077781553/job/16488029912?pr=381)

Though it's just a single file (dtlslistener.go) that was modified and the updated pion/transport/udp package is used on 3 lines, so creating and maintaining a go1.18 version of that code (which will be deleted once we drop go1.18 support) won't be hard.

hasheddan commented 1 year ago

Closing in favor of https://github.com/plgd-dev/go-coap/pull/481