search

plgd-dev / go-coap

Implementation of CoAP Server & Client in Go
https://coap.technology
Apache License 2.0
446 stars 116 forks source link

Jkralik/fix udp server test #494

Closed jkralik closed 11 months ago

codecov-commenter commented 11 months ago

Codecov Report

Merging #494 (032259b) into master (4683ac4) will increase coverage by 0.08%. The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #494      +/-   ##
==========================================
+ Coverage   72.22%   72.31%   +0.08%     
==========================================
  Files          70       70              
  Lines        5455     5447       -8     
==========================================
- Hits         3940     3939       -1     
+ Misses       1120     1113       -7     
  Partials      395      395

see 6 files with indirect coverage changes

sonarcloud[bot] commented 11 months ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

HRogge commented 11 months ago

@jkralik I am a bit confused... you requested a review, I did a review and you requested another review... something missing?

jkralik commented 11 months ago

@jkralik I am a bit confused... you requested a review, I did a review and you requested another review... something missing?

Sorry for the confusion. I added you as a reviewer because the pull request is based on your original one. This is just to ensure that everything you did is included :).