Closed jkralik closed 11 months ago
Attention: 47 lines
in your changes are missing coverage. Please review.
Comparison is base (
d63d5c8
) 72.52% compared to head (7e6b2bb
) 73.85%.
Files | Patch % | Lines |
---|---|---|
net/connUDP.go | 77.83% | 40 Missing and 5 partials :warning: |
message/pool/message.go | 80.00% | 1 Missing and 1 partial :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Just re-tested with the current commit, still works fine.
@HRogge Pls this is a final state. Could you check if it works as it is expected ?
Kudos, SonarCloud Quality Gate passed!
@HRogge Pls this is a final state. Could you check if it works as it is expected ?
It seems that multicast transmission is broken... not sure why, still trying to understand. I get neither a compiler nor a runtime error when using WriteMulticast() on net.UDPConn
I also get a broken Date for the current commit when I look at it with 'git log':
commit 7e6b2bbd34f0051d0ff09d06af2d453450a30706 (HEAD -> jkralik/feature/udp-propagate-interface, github-upstream/jkralik/feature/udp-propagate-interface)
Author: Jozef Kralik <jojo.lwin@gmail.com>
Date: Wed May 10 15:11:10 2023 +0000
Update UDP: Ensure propagation of control message to pool.Message
This commit enhances the UDP functionality, ensuring proper dissemination
of control messages to pool.Message for improved network coordination
and responsiveness
@HRogge Pls this is a final state. Could you check if it works as it is expected ?
It seems that multicast transmission is broken... not sure why, still trying to understand. I get neither a compiler nor a runtime error when using WriteMulticast() on net.UDPConn
It seems my multicast now ignores the specified interface and goes along the default route (into my local management interface).
@HRogge Pls this is a final state. Could you check if it works as it is expected ?
It seems that multicast transmission is broken... not sure why, still trying to understand. I get neither a compiler nor a runtime error when using WriteMulticast() on net.UDPConn
It seems my multicast now ignores the specified interface and goes along the default route (into my local management interface).
facepalm okay, got the problem resolved... stupidity on my side.
This commit enhances the UDP functionality, ensuring proper dissemination of control messages to pool.Message for improved network coordination and responsiveness