Closed jkralik closed 3 months ago
[!IMPORTANT]
Review skipped
More than 25% of the files skipped due to max files limit. The review is being skipped to prevent a low-quality review.
22 files out of 79 files are above the max files limit of 50. Please upgrade to Pro plan to get higher limits.
You can disable this status message by setting the
reviews.review_status
tofalse
in the CodeRabbit configuration file.
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
https://github.com/plgd-dev/hub/pull/1336#discussion_r1663991640
This depends on the cluster where the hub is running. In production, each user needs to set up their own cluster. If we set the limits too low, the processes will be killed by OOM (Out of Memory) errors.
@coderabbitai review
@coderabbitai summary
@coderabbitai summary
[!IMPORTANT]
Review skipped
More than 25% of the files skipped due to max files limit. The review is being skipped to prevent a low-quality review.
22 files out of 79 files are above the max files limit of 50. Please upgrade to Pro plan to get higher limits.
You can disable this status message by setting the
reviews.review_status
tofalse
in the CodeRabbit configuration file.
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
@coderabbitai create summary over files under m2m-oauth-server directory and helm chart
[!TIP] For best results, initiate chat on the files or code changes.
@jkralik, here is the summary of the changes:
m2m-oauth-server
Directorym2m-oauth-server/test/test.go
RequestBuilder
struct and associated methods, as well as an HTTPDo
function.If you need further details or have any other requests, please let me know.
@coderabbitai create summary over all files under m2m-oauth-server and charts directories
[!TIP] For best results, initiate chat on the files or code changes.
@jkralik, here is the updated summary of the changes:
m2m-oauth-server
Directorym2m-oauth-server/test/test.go
RequestBuilder
struct and associated methods, as well as an HTTPDo
function.charts
Directorycharts
directory.If you need further details or have any other requests, please let me know.
@coderabbitai create a description for whole pull request based on m2m-oauth-server
and charts
directories
[!TIP] For best results, initiate chat on the files or code changes.
@jkralik, here is the comprehensive description of the pull request based on changes in the m2m-oauth-server
and charts
directories:
The primary objective of this pull request is to allow configuring multiple authorities for m2m-token.
m2m-oauth-server
Directorym2m-oauth-server/test/test.go
RequestBuilder
struct and associated methods (NewRequestBuilder
, AddQuery
, Build
).HTTPDo
function.charts
DirectoryThis cleanup in the m2m-oauth-server
directory helps in maintaining a cleaner codebase and removing unused code. If there are any specific changes related to the configuration of multiple authorities for m2m-token that are not evident in the provided diffs, please let me know so I can include them in the description.
If you need further details or have any other requests, please let me know.
Issues
0 New issues
1 Accepted issue
Measures
0 Security Hotspots
80.0% Coverage on New Code
1.4% Duplication on New Code
Description
This PR introduces the
m2m-token
functionality, enabling the execution of trigger commands from various services. Them2m-token
is issued by them2m-oauth-server
through the credential flow.To obtain the token, users can utilize a secret or another JWT token signed by an authority configured within the
m2m-oauth-server
.Key highlights of this implementation include:
m2m-oauth-server
for token issuance.