coderabbitai[bot]
commented
2 months ago Walkthrough
This update introduces a new job for Helm chart testing in the GitHub workflow and integrates a boolean field, snippet_service, into various components of the grpc-gateway and http-gateway. Enhancements also include the ability to handle device authorization through iframes or new tabs, an update to the Scylla version in the Dockerfile, and several refactors to improve code clarity and functionality across the board.
Changes
| File(s) | Change Summary |
|---|---|
.github/workflows/test.yml |
Added a new job test-helm to set up Helm, add dependencies, and template Helm charts. |
grpc-gateway/pb/README.md, grpc-gateway/pb/doc.html, grpc-gateway/pb/hubConfiguration.proto |
Introduced a new boolean field snippet_service to the configuration options and documented it in README and HTML files. |
http-gateway/service/config.go |
Added SnippetService field to MainSidebarConfig struct and updated serialization logic. |
tools/tools.go |
Added import for "github.com/helm/chart-testing/v3/ct". |
bundle/Dockerfile |
Updated Scylla version from 5.2 to 5.4. |
dependency/googleapis, http-gateway/web/packages/shared-ui |
Updated subproject commit hashes. |
http-gateway/web/src/containers/App/slice.ts |
Enhanced setThemes function to initialize state.configuration if it does not exist. |
http-gateway/web/src/containers/Devices/List/ProvisionNewDevice/ProvisionNewDevice.tsx |
Added detect and isSafari imports, resetIndex state, modified handleFetch to include isBrave detection, and updated ProvisionDeviceModal component. |
http-gateway/web/src/containers/Devices/rest.ts |
Enhanced device authorization code retrieval with getCodeByIframe and getCodeByNewTab functions. Updated getDeviceAuthCode to accept newTab parameter. |
http-gateway/web/src/containers/SnippetService/Configurations/DetailPage/JsonConfigModal.tsx |
Updated import path for ModalFooter. |
http-gateway/web/src/containers/SnippetService/hooks.ts |
Reordered imports and removed commented-out code. |
http-gateway/web/src/routes.tsx |
Updated visibility property in getMenu function to use menuConfig.snippetService. |
Sequence Diagram(s)
sequenceDiagram
participant User
participant Config
participant System
User->>System: Request device auth code
alt newTab = true
System->>System: Open new tab for auth code
System->>User: Return auth code
else
System->>System: Retrieve auth code via iframe
System->>User: Return auth code
endPoem
In the code where changes bloom,
Helm and charts now find their room.
Snippet service joins the crew,
Device codes fetch in ways anew.
Scylla's version takes a leap,
While configurations smoothly sweep.
Code refined with grace and care,
New features live in lines laid bare. 🐇✨
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
sonarcloud[bot]
Snippet Service Menu Visibility: The visibility of the snippet service menu is now controlled through the well-known configuration settings. This change ensures that the menu visibility can be dynamically managed and easily adjusted based on configuration.
Brave/Safari Browser Device Code Retrieval: Updated the approach for obtaining the device code to ensure compatibility with the Brave/Safari browser. This modification addresses specific challenges related to Brave's unique privacy features and enhances the user experience for Brave/Safari browser users.