plgd-dev / hub

Secure and Interoperable Internet of Things
https://plgd.dev
Apache License 2.0
171 stars 17 forks source link

LeftSidebar add routing check for snippetService #1365

Closed PatrikMatiasko closed 3 weeks ago

PatrikMatiasko commented 3 weeks ago

Summary Routing Checks: Added validation for snippetService and deviceProvisioning. Details Introduced routing checks to ensure that navigation is properly handled for snippetService and deviceProvisioning. These checks verify that the correct routing logic is applied, preventing navigation to invalid routes.

coderabbitai[bot] commented 3 weeks ago

[!IMPORTANT]

Review skipped

Review was skipped due to path filters

Files ignored due to path filters (1) * `charts/plgd-hub/templates/snippet-service/deployment.yaml` is excluded by `!**/*.yaml`

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Walkthrough

The recent changes enhance the application's routing logic by introducing conditional rendering based on the mainSidebar state, ensuring specific routes like /device-provisioning and /snippet-service are only visible when activated. Additionally, a shared UI subproject has been updated to a new commit, likely integrating important fixes or features, although specific details were not disclosed. Overall, these modifications improve user experience and maintainability.

Changes

File Path Change Summary
http-gateway/web/packages/shared-ui Updated subproject commit from 7b292e90... to bf374fcfd..., reflecting potential updates.
http-gateway/web/src/routes.tsx Implemented conditional rendering for /device-provisioning and /snippet-service routes based on mainSidebar flags.
.golangci.yml Enabled copyloopvar linter; disabled exportloopref linter to adjust linting behavior.
Makefile Enhanced MongoDB configuration with conditional verbosity settings for better command handling.
bundle/client/coap/main.go Added linter suppression comments to bypass security warnings without changing functionality.
bundle/client/grpc/main.go Added linter suppression comments next to ContentType assignment for security warnings.
cloud2cloud-connector/service/... Refined logic in handleResourcesPublished and publishResource for better type handling and clarity.
coap-gateway/... Various improvements in function names, lint comments, and handling of BitFlags across multiple files.
device-provisioning-service/... Adjusted default CoAP API address in README.md and added lint suppression comments in configuration files.
grpc-gateway/pb/... Changed priority field type from int64 to uint64 for better data handling.
resource-aggregate/... Introduced a new function for bit flag conversion and modified existing functions for clarity and type safety.
pkg/net/coap/service/... Updated MessagePoolSize type to uint32 and improved related configurations.
pkg/net/grpc/server/makeDefaultOptions.go Added linter suppression comment for newTags.Set to handle security warnings.
tools/mongodb/standby-tool/main.go Added linter suppression comments in two functions without altering their logic.

Poem

🐰 In the world of code where ideas sprout,
New routes emerge, and workflows twist about!
With flags that guide what users might see,
A swift and smooth UI, like a rabbit, we flee!
So let's hop with joy, for each change brings cheer,
A celebration of progress, with friends drawing near! 🎉


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit .` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai generate interesting stats about this repository and render them as a table.` - `@coderabbitai show all the console.log statements in this repository.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (invoked as PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. Additionally, you can add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. ### CodeRabbit Configuration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.
sonarcloud[bot] commented 3 weeks ago

Quality Gate Failed Quality Gate failed

Failed conditions
74.1% Coverage on New Code (required ≥ 75%)

See analysis details on SonarCloud