search

plibither8 / refined-hacker-news

✨ Hacker News, but refined — Interface tweaks and features to make the HN experience better
MIT License
808 stars 34 forks source link

Infinite loading at the homepage #109

Closed fireattack closed 2 years ago

fireattack commented 2 years ago 
Uncaught (in promise) TypeError: Cannot read properties of null (reading 'href')
    at getGroupedStories (refined-hacker-news.js:2761)
    at requestVisitedStories (refined-hacker-news.js:2907)
    at hide_read_stories_init (refined-hacker-news.js:2958)
    at refined-hacker-news.js:3024
    at new Promise (<anonymous>)
    at Object.add (refined-hacker-news.js:3020)
    at initialiseAll (refined-hacker-news.js:5128)

At

https://github.com/plibither8/refined-hacker-news/blob/ec1ddb19119b56f73a85ad79dd0a995d03124074/src/libs/dom-utils.js#L70

There is no storylink class on the page at all, only titlelink. Not sure if that's something gets changed recently on HN's side.

fnordson commented 2 years ago

I have the same issue.
Sorting not possible also and constant loading animation:

grafik

Firefox 93.0 Windows 10

plibither8 commented 2 years ago

Ah damn it, this seems to be a change in the code of HN itself. I'll post a quick fix for this by EOD. Thanks a lot for bringing it to my attention! :) @fireattack @fnordson

plibither8 commented 2 years ago

@fireattack @fnordson I've pushed a fix and updated the versions on the Chrome and Firefox stores. The FF Add-on should be up and live in a few minutes but Chrome usually takes a few days to review and publish it. Thanks again :)

fnordson commented 2 years ago

Got it. Thank you it fixed the problem :)