search

plibither8 / refined-hacker-news

✨ Hacker News, but refined — Interface tweaks and features to make the HN experience better
MIT License
807 stars 34 forks source link

Feature request: configurable keybindings #39

Open infokiller opened 5 years ago

infokiller commented 5 years ago

This can be done similarly to https://github.com/infokiller/web-search-navigator by adding an options page and storing the options in browser.sync.

Happy to send a PR if you are open to merging.

Related HN comment: https://news.ycombinator.com/item?id=20189188

Thanks!

plibither8 commented 5 years ago

Hi! This seems like a good idea :)

By adding a separate options page that is different from the popup page, we will have two places where one sets the extension settings, which doesn't look too good. All settings/options regarding the extension should be at one place only - either the popup or the options page.

Could you explain a bit more on how you will implement this in the code? Or better still, if you could create the PR, I can look at the code then and we can discuss about it.

Nevertheless, this is a nice enhancement which I'll be happy to look into.

Cheers!

infokiller commented 5 years ago

Oh I wasn't aware of the pop up page, yes it definitely makes sense to add the customizations to that page. Great, will send a PR soon.

plibither8 commented 5 years ago

Great!

plibither8 commented 5 years ago

Hey @infokiller, any updates regarding this?

infokiller commented 5 years ago

Sorry, didn't get to this yet... Hope to do it soon

plibither8 commented 5 years ago

Alright!