search

plibither8 / refined-hacker-news

✨ Hacker News, but refined — Interface tweaks and features to make the HN experience better
MIT License
807 stars 34 forks source link

can't enter "i" in the reply box #59

Closed isrbaral closed 5 years ago

isrbaral commented 5 years ago

when ever I enter "i" or "I" in the reply textbox the page redirects to https://news.ycombinator.com/undefined

plibither8 commented 5 years ago

Hi, I really apologize for this bug. This was introduced two commits back and I had pushed a fix for it, but Chrome Web Store did not allow me to roll the version back. I have recently pushed an update to the extension that fixes this issue and you shall soon receive it. Until then, please disable site-navigation-key-bindings function. Thank you so much for your patience!

plibither8 commented 5 years ago

Hi! I'd like to tell you that the extension has successfully been updated on the Chrome Web Store. If you want you can manually update it too! Thanks!

compuguy commented 5 years ago

That did the trick @plibither8 (Disabling site-navigation-key-bindings at least. The chrome web store hasn't pushed it out yet).

PierBover commented 5 years ago

I'm having a similar issue when I press h I go home.

Honestly all these key bindings should never be activated by default, specially when you are writing a comment...

plibither8 commented 5 years ago

I'm apologize for that @PieBover. Ideally the feature had mapped Home for Alt+H but a incorrect, buggy version of the extension which I pushed had incorrect mappings. I pushed the fixed version yesterday, so please update to the latest version. Thanks a lot.

PierBover commented 5 years ago

No worries, thanks again for your work on this extension. It's super helpful!