Closed jvzr closed 4 years ago
Hi! Excellent PR :+1:
I've given it a test and it looks all okay to me. Before merging to master, I'd like you to run the linter to see that the code conforms to the predefined code-style. Run it like this: npm run lint
to see the errors and npm run lint-fix
to automatically fix most of them. Some of the errors you might have to manually fix.
Will do tonight!
Hey @plibither8 I've run lint and lint-fix but I'm afraid I messed something up. It corrected a lot of files' line ending from LF to CRLF, hence creating a lot of changes. Regarding the actual code, there are minor stylistic differences in collapse-root-comment.js, a var unused (metadata in init()) and a non-camelCase variable. I've fixed that, but I'm afraid to commit so many changes What's going on? I'm sorry to come with such a problem
I'm stupid. It should be OK now. Can you confirm? @plibither8
Whoops, somehow my reply to your previous query did not get submitted properly, apologies!
Just checked your commit, great stuff! Also I really like the "auto-scroll", nice touch.
Thanks for your work on this feature, cheers!
Just FYI, I've uploaded the updates to Mozilla and Chrome Web Store. Should update in some time. Congratulations! :smile:
You're very kind, @plibither8! Thank you for guiding me through my first ever OS submission 😉
It was my pleasure, loved to help! Do ping me any time you have any other issues :)
Have a good day!
just want to say thanks for this PR 👍
Adds a [collapse root] button on child comments, which collapses that comment's root.
Closes #61