plibither8 / refined-hacker-news

✨ Hacker News, but refined — Interface tweaks and features to make the HN experience better
MIT License
807 stars 34 forks source link

Fixes #61: Feat: Make child's root comment collapseable #63

Closed jvzr closed 4 years ago

jvzr commented 4 years ago

Adds a [collapse root] button on child comments, which collapses that comment's root.

Closes #61

plibither8 commented 4 years ago

Hi! Excellent PR :+1:

I've given it a test and it looks all okay to me. Before merging to master, I'd like you to run the linter to see that the code conforms to the predefined code-style. Run it like this: npm run lint to see the errors and npm run lint-fix to automatically fix most of them. Some of the errors you might have to manually fix.

jvzr commented 4 years ago

Will do tonight!

jvzr commented 4 years ago

Hey @plibither8 I've run lint and lint-fix but I'm afraid I messed something up. It corrected a lot of files' line ending from LF to CRLF, hence creating a lot of changes. Regarding the actual code, there are minor stylistic differences in collapse-root-comment.js, a var unused (metadata in init()) and a non-camelCase variable. I've fixed that, but I'm afraid to commit so many changes What's going on? I'm sorry to come with such a problem

jvzr commented 4 years ago

I'm stupid. It should be OK now. Can you confirm? @plibither8

plibither8 commented 4 years ago

Whoops, somehow my reply to your previous query did not get submitted properly, apologies!

Just checked your commit, great stuff! Also I really like the "auto-scroll", nice touch.

Thanks for your work on this feature, cheers!

plibither8 commented 4 years ago

Just FYI, I've uploaded the updates to Mozilla and Chrome Web Store. Should update in some time. Congratulations! :smile:

jvzr commented 4 years ago

You're very kind, @plibither8! Thank you for guiding me through my first ever OS submission 😉

plibither8 commented 4 years ago

It was my pleasure, loved to help! Do ping me any time you have any other issues :)

Have a good day!

Wakeupbuddy commented 3 years ago

just want to say thanks for this PR 👍