search

plibither8 / refined-hacker-news

✨ Hacker News, but refined — Interface tweaks and features to make the HN experience better
MIT License
808 stars 34 forks source link

Fix: Avoid pulling top color from "black bar" #72

Closed T0astBread closed 4 years ago

T0astBread commented 4 years ago

HN is currently running a "black bar" (see the comment in my patch) which screws up the top color detection and makes the username dropdown pitch black.

RHN with a pitch black dropdown

This patch handles that (rare) condition.

plibither8 commented 4 years ago

Hi! Apologies for reviewing this so late, couldn't get a chance to till now (quarantine ftw!).

I've reviewed your commit with a minor change, I hope you can look into it, otherwise I will merge the PR and apply the change myself.

Thanks for creating the PR :)

T0astBread commented 4 years ago

I'm sorry, what change do you mean? I don't see anything.

plibither8 commented 4 years ago

I've started a review and requested a change here: https://github.com/plibither8/refined-hacker-news/pull/72/files/6acba81191e5efde54d62a777a39ab4688036a13

You can view this on GitHub's website, if you're using a third-party application right now.

Essentially:

- let topcolor = 'red';
+ let topcolor = '#ff6600';
T0astBread commented 4 years ago

I approve of the change but GitHub (.com) does not show me that anywhere.

Hold on, I'll commit that real quick.

plibither8 commented 4 years ago

Hmm, that's weird. Nevertheless, I'll merge to master now :)

Thanks, and stay safe! =)

T0astBread commented 4 years ago

Now I see the change request. GitHub says it has been posted 5 minutes ago, maybe you forgot to submit something?

Anyways, thanks for merging and for this addon!

plibither8 commented 4 years ago

Hmm, could be possible. No problem :D I've uploaded the updated package on Mozilla Add-ons and Chrome Webstore too.