The STATUS command has been added to shortcut list

plibither8 / ulauncher-nordvpn

🔑 Connect to and disconnect from NordVPN from Ulauncher

MIT License

4 stars 4 forks source link

The STATUS command has been added to shortcut list #2

Open OdinsHat opened 2 years ago

OdinsHat commented 2 years ago

I've added the NordVPN status command to the list of options along with connect and disconnect.

Screenshot_20220313_174940

The output of the command is sent to Utils.notify() with the title being the status "Connected" or "Disconnected".

So the message could be read I also increased the notify timeout to 2500ms so you can see the information provided. E.g. country, IP, etc.

Potential future update:

Add setting to change notification time?
Change the status results to be list items similar to how IP analysis does and allow copying of these values by clicking enter on them.

plibither8 commented 2 years ago

Hey @OdinsHat! 👋

Thanks so much for contributing! I unfortunately don't use Linux as my daily driver, and won't be able to test your changes - or personally make code-contributions (in regards to your suggestions). However, I trust that you've properly tested it so that it doesn't cause any regression 😄. And as for the potential future updates, sounds great! If you could take them up, I'd be more than happy to merge it :D.

Cheers!

plibither8 commented 2 years ago

Psst I'll wait for one last go-ahead from you before merging this PR 😄

OdinsHat commented 2 years ago

Thanks @plibither8 - glad I could help! I've tested it on my main Arch laptop and double-checked it on Parrot Sec which is Debian-based and both work fine with no extra requirements. :)