issue in Softuart_Putchar

plieningerweb / esp8266-software-uart

Software UART / Software Serial / SoftUart for ESP8266 to connect more than one UART

MIT License

123 stars 42 forks source link

Closed emichel11 closed 7 years ago

emichel11 commented 7 years ago

The for loop in Softuart_Putchar has an issue. It runs 9 times instead of 8. it should read for(i = 0; i < 8; i ++ )

plieningerweb commented 7 years ago

Could you do a pull request?

emichel11 commented 7 years ago

It seems I do not have the permission. My push fails. for(i = 0; i <= 8; i ++ ) should be changed to for(i = 0; i < 8; i ++ ) in line 324

plieningerweb commented 7 years ago

Thanks for the issue!

Regarding the pull request: Usually you do first a fork on github, then push to your own repository, then do a pull request to this repository.

Thanks for reporting, let me know if the issue is solved now!