search

plietar / librespot

Open Source Spotify client library
MIT License
1.14k stars 184 forks source link

Change system_information_string according to request from Spotify #218

Closed fabian-z closed 7 years ago

fabian-z commented 7 years ago

In communication with @sashahilton00, Spotify requested us to use a system_informationstring that looks like ```librespot[short sha]_[random 8 characters build id]```.

Original PR: #207

It extends version.rs, which is generated by vergen. The build script will only execute if there is no cache or the file changed - so generating a new ID (or version information) after the first build has to be done with cargo clean && cargo build.

Of course pushing this or a similar functionality upstream should be considered afterwards.

herrernst commented 7 years ago

For me, this works! Thanks!

awiouy commented 7 years ago

This works and has been added to LibreELEC

Bebowi commented 7 years ago

It works for one song. After that ALSA lib pcm.c:7843:(snd_pcm_recover) underrun occurred ALSA lib pcm.c:7843:(snd_pcm_recover) underrun occurred ERROR:librespot::audio_backend::portaudio: PortAudio write underflow like #102 occurs.

Does anybody know what to do about that issue?

lassos commented 7 years ago

Yes. Your are right. I havent found this fix cause the thread was closed. Compiled with this fix works for me . THX .-)

plietar commented 7 years ago

Thanks

fabian-z commented 7 years ago

@Bebowi I doubt the error you are experiencing is related to this PR, since my commit does not touch anything directly related to the audio pipeline. Please try to use another backend or continue in #102

@plietar You're welcome, glad I could help. Thanks for merging!