plietar / librespot

Open Source Spotify client library
MIT License
1.14k stars 185 forks source link

Authentication failure when password contains special characters #225

Open RyanMelenaNoesis opened 7 years ago

RyanMelenaNoesis commented 7 years ago

I was experiencing a crash in spotty when using a Spotify password that contained '$'. After changing the password to eliminate special characters the problem was resolved.

spotty -n test -c /tmp -u <accountName> -p <password with $ in it> --disable-discovery _thread 'main' panicked at 'Authentication failed', /mnt/hgfs/git/spotty/target/i686-unknown-linux-musl/release/build/librespot-8e0c60f10117bf90/out/lib.rs:365 note: Run with RUSTBACKTRACE=1 for a backtrace. Aborted (core dumped)

mherger commented 7 years ago

Spotty is a small tool based on the librespot application https://github.com/michaelherger/spotty

simias commented 7 years ago

Something trivial but: are you sure the problem is not simply that your shell interpreted the '$'? Was it escaped correctly? If the shell expanded it then it's not surprising that it ended up being invalid.

FWIW my password also contains a '$' and I authenticated successfully using librespot. Didn't try with spotty however.

michaelherger commented 7 years ago

BTW: is this a dupe of issue #210?

michaelherger commented 7 years ago

FWIW: the command line used to authenticate does put quotes around those values.