plietar / librespot

Open Source Spotify client library
MIT License
1.13k stars 187 forks source link

Add album type 'EP' #255

Closed XDjackieXD closed 6 years ago

XDjackieXD commented 6 years ago

Spotify seemingly added the album type "EP" which crashes librespot when attempting to load album metadata for such an album (spotify:album:5UlvhrjweEYAHFvwyzuV6U for example).

plietar commented 6 years ago

Thanks !

sashahilton00 commented 6 years ago

Now that's what I call efficient :)

mfonville commented 6 years ago

The checksum is broken now, in protocol/files.rs the following diff should be applied:

@@ -4,7 +4,7 @@ pub const FILES : &'static [(&'static str, u32)] = &[
     ("proto/authentication.proto", 2098196376),
     ("proto/keyexchange.proto", 451735664),
     ("proto/mercury.proto", 709993906),
-    ("proto/metadata.proto", 3146937699),
+    ("proto/metadata.proto", 2474472423),
     ("proto/pubsub.proto", 2686584829),
     ("proto/spirc.proto", 3618770573),
 ];
XDjackieXD commented 6 years ago

Yeah sorry... forgot to recalc the checksums after fixing the indentation.