plin012
commented
7 years ago Thank you for your feedback, William.
Pei Lin
Open Emik234 opened 7 years ago
plin012
commented
7 years ago Thank you for your feedback, William.
Pei Lin
Reviewer name: William Project name: Dasmoto Arts & Crafts Summary Grade: Satisfactory
Great job on the visual design of the site. It matched well and your indentation was great, making it easier to read the code. in addition, I liked that you wrapped everything under a div class called "Subheading". This is especially useful as it's very similar to how Bootstraps grid system works and how these areas would normally be grouped together. Great job on thinking outside the specs!
The areas of improvement I would say is adding multi-line comments to better section out your HTML and CSS so that it’s easier to cross reference the selectors with the class names or ID’s in the event something needs to be modified.
As a further challenge, consider adding a full background image. This will take some extra research but could be a really valuable way to challenge yourself to push past what you’ve already learned. Based on your work here, I think it’s a challenge you’re ready for.