search

plinkysynth / plinky_public

a public release of the plinky sw and hw
Other
126 stars 17 forks source link

Sequencer issue #16

Open xxv opened 5 months ago

xxv commented 5 months ago

There seems to be a bug with the sequencer with the new live-play-on-top functionality (#14). Even if you're not in record mode, it'll still record over your sequenced notes when you play on the strings that are being played via the sequencer.

Specifically, when it's playing a string on the sequencer, if you're touching the same string when it plays it, it'll add the touched note to the same string on the same sequence step, which causes it to do a little worble.

carlosedp commented 4 months ago

I also tried the "overdub" functionality and the new notes replace the previously recorded ones when the new notes are on different strings.

The workflow I did was: press record (it lits), press play (playhead starts) and I go playing over even when the sequencer loops around.

makingsoundmachines commented 2 months ago

For the current build 0.A4, Merge Playback is disabled again.

Here's a brief description of the Merge issue by Zephyrus from Discord:

The feature was "when in seq rec mode, you can live record notes and add them to your existing seq." The bug is "when you are NOT in rec mode and play a note, the sequence pattern preset is messed up and notes are replaced." Because it permanently changes saved pattern presets without any undo, its not a small thing.

For anyone interested to look into it, the flag to enable / disable is MERGE_PLAYBACK in touch.h.