search

plinss / flake8-noqa

flake8 plugin to validate #noqa comments - Mirror of https://gitlab.linss.com/open-source/flake8/flake8-noqa
GNU Lesser General Public License v3.0
41 stars 6 forks source link

Support flake8==5 #16

Closed jonyscathe closed 2 years ago

jonyscathe commented 2 years ago

Currently setup.py is limiting flake8 < 5 I would like to move to flakeu8==5.0.2. Does anything (other than setup.py) need to change for this?

plinss commented 2 years ago

I'm generally conservative allowing new releases of flake8 because this plugin does do a small amount of monkey patching, so it's always possible that a new release a flake8 will break it. But the unit tests look good on flake8 5.0.3.

Thanks for the ping, I wasn't aware 5.0 had shipped.

jonyscathe commented 2 years ago

Thanks for the quick fix!