search

plivesey / RocketData

A caching and consistency solution for immutable models.
https://plivesey.github.io/RocketData
Apache License 2.0
648 stars 50 forks source link

fix thinking Model to SimpleMode error #80

Closed elijahdou closed 6 years ago

elijahdou commented 6 years ago

In RocketData/Model.swift file, line 121, according to my understanding, Model should be SimpleModel

codecov[bot] commented 6 years ago

Codecov Report

Merging #80 into master will not change coverage. The diff coverage is 0%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #80   +/-   ##
=======================================
  Coverage   93.81%   93.81%           
=======================================
  Files          47       47           
  Lines        4784     4784           
=======================================
  Hits         4488     4488           
  Misses        296      296
Impacted Files Coverage Δ
RocketData/Model.swift 47.91% <0%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 5d23a6a...e4ee5b6. Read the comment docs.

plivesey commented 6 years ago

Thanks a lot for the PR. I’m camping right now with limited access to internet but should have a chance to look at this on Wednesday.

On Mon, Aug 20 2018 at 2:17 AM, < notifications@github.com > wrote:

In RocketData/Model.swift file, line 121, according to my understanding, Model should be SimpleModel

You can view, comment on, or merge this pull request online at:

  https://github.com/plivesey/RocketData/pull/80

Commit Summary

  • fix thinking Model to SimpleMode error

File Changes

Patch Links:

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub ( https://github.com/plivesey/RocketData/pull/80 ) , or mute the thread ( https://github.com/notifications/unsubscribe-auth/ABMNTZfnRNtfvht_YDyVjgV_pyxNTnvgks5uSn63gaJpZM4WDoLY ).

plivesey commented 6 years ago

Great catch! Definitely fixes a bug. Thanks for this. Merging it in.

plivesey commented 6 years ago

I've published 6.0.1 with this change so you can upgrade on master. Thanks again.

elijahdou commented 6 years ago

@plivesey copy that，thanks for your library, we are applying it to our own project