search

plivo / plivo-node

A Node library for communicating with the Plivo API and generating Plivo XML.
https://www.plivo.com
MIT License
98 stars 62 forks source link

SMS-6010: Add DLT Params to Send and Get Message APIs #307

Closed mohsin-plivo closed 1 year ago

mohsin-plivo commented 1 year ago

Jira: https://plivo-team.atlassian.net/browse/SMS-6010

mohsin-plivo commented 1 year ago

LGTM. Shouldn't there be some changelog/version related changes on this?

Yes, Haven't added the changelog and version related changes on any of the SDK PRs yet. Since they don't impact the working, I plan to add those after QA is done to ensure the version change is up to date.

If we add right now, there might be some releases between today and QA complete making the version changes made right now obselete

aayush-plivo commented 1 year ago

LGTM. Shouldn't there be some changelog/version related changes on this?

Yes, Haven't added the changelog and version related changes on any of the SDK PRs yet. Since they don't impact the working, I plan to add those after QA is done to ensure the version change is up to date.

If we add right now, there might be some releases between today and QA complete making the version changes made right now obselete

Sure. Makes sense. Thanks.