search

plivo / plivo-php

Plivo PHP Helper Library
http://www.plivo.com
MIT License
110 stars 117 forks source link

Powerpack.php missing use #263

Closed haywiremk closed 2 years ago

haywiremk commented 2 years ago

Powerpack.php is missing use Plivo\Exceptions\PlivoValidationException;

resulting in error Error: Class 'Plivo\Resources\Powerpack\PlivoValidationException' not found in vendor/plivo/plivo-php/src/Plivo/Resources/Powerpack/Powerpack.php:204

haywiremk commented 2 years ago

Has this code been linted? While I have 4.25.2 (not pulling update that will wipe my changes to debug). Most only issues if you create an exception

Files with missing use statements Numbers.php (PlivoValidationException) Shortcode.php (PlivoValidationException) Tollfree.php (PlivoValidationException) ComplianceDocumentTypeInterface.php (PlivoResponseException)

Files with use statements that are not used (just flagged when finding the missing ones above) AddressInterface.php BrandInterface.php CallFeedbackInterface.php CampaignInterface.php MediaInterface.php MessageInterface.php MultiPartyCall.php Numberpool.php Numbers.php PowerpackInterface.php Shortcode.php Tollfree.php MessageClient.php

Random other odd flags PlivoGuzzleHttpClient.php -> line 110: $requestBody = $requestBody;

narayana-plivo commented 2 years ago

Fix deployed on PR 270. @mallika-plivo