search

plivo / plivoframework

Open Source Telephony Application Prototyping Framework
http://www.plivo.com/open-source/
Other
418 stars 179 forks source link

Shouldn't the recording result be sent even after hangup? #28

Closed mkhattab closed 13 years ago

mkhattab commented 13 years ago

Hi,

I'm trying to implement voicemail functionality using Plivo, but when a recording is made and the caller hangs up before reaching the time limit, it doesn't send the result to the action url specified.

Browsing through the code, I found this: elements.py line 1346

            # don't send record result if call has hangup
            self.fetch_rest_xml(self.action, params, method=self.method)

If this can't be changed, is there a work around I could implement?

mkhattab commented 13 years ago

Ok, I see a potential work around is in issue 27

I'll just close this one because it looks it might be a PITA to fix this issue.

mike-plivo commented 13 years ago

ok =)

the comment " don't send record result if call has hangup" was wrong, I removed it.

Now rest xml is fetched even if call has hung up and raising RESTHangup exception is done after fetching.

re reading Record code, I found a little bug too, ... fixed now :)