plk / biblatex-apa

APA style for BibLaTeX
90 stars 48 forks source link

Incorrect handling of creator fields in reference entries for chapters reprinted from "book" .bib source entries #245

Open npearlmu opened 2 months ago

npearlmu commented 2 months ago

Two more connected "reprinted-from" issues (see also #243 and #244): With a "book" .bib source entry for a reprinted chapter, the "(Reprinted from..." part of the reference entry does not properly handle cases where the reprinted-from source entry either lacks an "editor" field or contains some other creator field(s) aside from "author" and "editor". E.g., using these two .bib file entries:

@book{Smith1975,
  title = {Old Book Title},
  editor = {Doe, D.},
  author = {Smith, A.},
  date = {1975},
  pages = {1--10},
  publisher = {Pub75},
}

@incollection{Smith1980,
  title = {Chapter Title},
  booktitle = {New Book Title},
  author = {Smith, A.},
  editor = {Jones, J.},
  date = {1980},
  pages = {11--20},
  publisher = {Pub80},
  related = {Smith1975},
  relatedtype = {reprintfrom}
}

I get correct behavior; the reference entry for Smith1980 is:

Smith, A. (1980). Chapter title. In J. Jones (Ed.), New book title (pp. 11–20). Pub80. (Reprinted from Old book title, pp. 1–10, by D. Doe, Ed., 1975, Pub75)

But if the "editor" field is removed from the Smith1975 entry, the "(Reprinted from..." section becomes:

(Reprinted from Old book title, pp. 1–10, by, Ed., 1975, Pub75)

(Note the presence of "by, Ed.," without any editor name included.) If there is no creator information in the source entry, then that element should just be skipped in the output; we should get something like:

(Reprinted from Old book title, pp. 1–10, 1975, Pub75)

In addition, other creator fields (e.g., "author", "translator") in the source entry are ignored. Presumably, they should be taken into account, so that (e.g.) if a source entry has a translator but no editor, the translator should be shown (and noted as such, rather than as "Ed.").


The above seem like specific bugs; then there are also some related issues that might not be as easily/clearly resolvable:

If the editor is also listed as translator, then presumably both roles should be noted? (Not entirely clear what/which should be shown if there are distinct editor and translator (e.g.) fields in the entry.)

It's also less clear about the author field in the source entry, and I don't actually have the APA7 manual immediately available, but for a source book that just has an author (e.g., when a chapter from an author's book (not an edited book) has been reprinted elsewhere), should the author be shown in the "(Reprinted from..." section (even though it would not be included when there's another creator type involved)?

Note these interact especially with #243, as if the source entry could be of "incollection" type, specifying the various creator roles as they applied to the source chapter vs the source book would be more straightforward.