pln-planning-tools / Starmap

Roadmap Planning Tool
https://starmap.site
Other
20 stars 8 forks source link

fix: milestone card ux updates #282

Closed 0xDanomite closed 1 year ago

0xDanomite commented 1 year ago

fixes: #273

demo: https://starmaps-9rwlhr85y-ipfs-ignite.vercel.app/roadmap/github.com/ipfs/go-libipfs/issues/54#detail

vercel[bot] commented 1 year ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
starmaps ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Jan 27, 2023 at 1:26AM (UTC)
whizzzkid commented 1 year ago

KIs:

gh-icon

0xDanomite commented 1 year ago

@whizzzkid updated the github icon. As for the hover state of the cards the hover border change should only occur if there are children for the issue

SgtPooki commented 1 year ago

@djmcquillan when is the github icon supposed to be muted? I would imagine it should be muted at all times unless hover over.. but I'm not sure what you and @juliaxbow talked about

0xDanomite commented 1 year ago

@djmcquillan when is the github icon supposed to be muted? I would imagine it should be muted at all times unless hover over.. but I'm not sure what you and @juliaxbow talked about

just based on the figma designs the github icon is always muted unless hovered - update was made to address the non-muted icons in latest commit.

whizzzkid commented 1 year ago

@djmcquillan I am still not seeing the muted icon, a few icons show up as unmuted/black

SgtPooki commented 1 year ago

demo looks much better

0xDanomite commented 1 year ago

demo looks much better

@SgtPooki are you ok with merging these changes in before we address the comments in #273 ?

SgtPooki commented 1 year ago

Yessir. thanks for double checking.. we can adjust later if necessary! Sounds like julia did all the design work required and I was late to the party. sorry for the holdup

SgtPooki commented 1 year ago

ugh. accidentally clicked close instead of comment