pln-planning-tools / Starmap

Roadmap Planning Tool
https://starmap.site
Other
20 stars 8 forks source link

fix: :wrench: Fixing env variable. #305

Closed whizzzkid closed 1 year ago

whizzzkid commented 1 year ago

Fixes broken test: https://github.com/pln-planning-tools/Starmap/actions/runs/4119220968

vercel[bot] commented 1 year ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
starmaps ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Feb 8, 2023 at 5:26AM (UTC)
whizzzkid commented 1 year ago

@SgtPooki So it looks like pull_request_target was the wrong key, their documentation is not super clear. It only seems to be running from the target branch.

This test should've broken before merge, but it did not. SW seems to mess up playwright. I added a step to skip that NO_SW=true

This might have to be overridden, to merge so that this rule changes on main and this error will go away from the next PR onwards.

Apologies for the inconvenience caused. 🙏🏽