pln-planning-tools / Starmap

Roadmap Planning Tool
https://starmap.site
Other
20 stars 8 forks source link

feat(ux): Adding Skeleton Loader To Starmap #309

Closed whizzzkid closed 1 year ago

whizzzkid commented 1 year ago

Closes: #68

In this PR:

Demo:

https://user-images.githubusercontent.com/1895906/217744858-5ae42f5c-f5d3-470a-93f6-c063774f51fb.mov

⚠️ Testing this could be hard with the service-worker, make sure to disable caching or reset cache between reloads. Also, throttling the network helps!

vercel[bot] commented 1 year ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
starmaps ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Feb 11, 2023 at 6:01PM (UTC)
SgtPooki commented 1 year ago

If we wrap most components with SkeletonLoader, we should be able to get this view:

Screen Shot 2022-11-10 at 1 58 02 PM

and then as the data for each section has what it needs, it's filled in appropriately

whizzzkid commented 1 year ago

@SgtPooki Resolved most comments, I think we can always improve this, thanks for the review! Ready for a second pass.

SgtPooki commented 1 year ago

@whizzzkid build is failing during testing: https://github.com/pln-planning-tools/Starmap/actions/runs/4148494639/jobs/7176537532

whizzzkid commented 1 year ago

@SgtPooki the build was failing because of the stringification of a Proxy object, replaced it with the random + date obj.