Closed whizzzkid closed 1 year ago
The latest updates on your projects. Learn more about Vercel for Git ↗︎
Name | Status | Preview | Comments | Updated |
---|---|---|---|---|
starmaps | ✅ Ready (Inspect) | Visit Preview | 💬 Add your feedback | Feb 11, 2023 at 6:01PM (UTC) |
If we wrap most components with SkeletonLoader, we should be able to get this view:
and then as the data for each section has what it needs, it's filled in appropriately
@SgtPooki Resolved most comments, I think we can always improve this, thanks for the review! Ready for a second pass.
@whizzzkid build is failing during testing: https://github.com/pln-planning-tools/Starmap/actions/runs/4148494639/jobs/7176537532
@SgtPooki the build was failing because of the stringification of a Proxy object, replaced it with the random + date obj.
Closes: #68
In this PR:
Demo:
https://user-images.githubusercontent.com/1895906/217744858-5ae42f5c-f5d3-470a-93f6-c063774f51fb.mov
⚠️ Testing this could be hard with the service-worker, make sure to disable caching or reset cache between reloads. Also, throttling the network helps!