pln-planning-tools / Starmap

Roadmap Planning Tool
https://starmap.site
Other
20 stars 8 forks source link

feat: implement direct children list view #341

Closed SgtPooki closed 1 year ago

SgtPooki commented 1 year ago

fixes https://github.com/pln-planning-tools/Starmap/issues/120

demo: https://starmaps-git-120-feature-request-create-a-vi-1e48b6-ipfs-ignite.vercel.app/roadmap/github.com/ipfs/ipfs-gui/issues/106#list

vercel[bot] commented 1 year ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
starmaps ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Mar 22, 2023 at 8:45PM (UTC)
whizzzkid commented 1 year ago

https://github.com/pln-planning-tools/Starmap/pull/342/ needs merging and rebase this ☝🏽 and it should be green.

SgtPooki commented 1 year ago

@whizzzkid ready for review now. sorry for the delay.

SgtPooki commented 1 year ago

Thanks for fixing the build, I am still seeing this: #341 (review)

did you get an opportunity to fix this?

I noticed some weirdness in the error display:

@whizzzkid What's the issue? that issues show up that then go away? I assume this is because we have partial data and then more full data (i.e. no ETA, then ETA) so it adds/removes appropriately.

I think it's fine as is, but I can do skeleton loading on errorNotificationDisplay if globalLoading is still true; would that satisfy issues you have with it?