search

pln-planning-tools / Starmap

Roadmap Planning Tool
https://starmap.site
Other
20 stars 8 forks source link

fix: d3-migration - breadcrumb navigation #371

Closed SgtPooki closed 1 year ago

SgtPooki commented 1 year ago

How to reproduce issues:

Browser back is broken

  1. visit http://localhost:3000/roadmap/github.com/ipfs/ipfs-gui/issues/106
  2. click any clickable milestone
  3. click browser back button
  4. notice that rendering doesn't update appropriately.

Breadcrumb renders duplicate titles

  1. visit http://localhost:3000/roadmap/github.com/ipfs/ipfs-gui/issues/106
  2. click any clickable milestone
  3. click browser back button
  4. click browser forward button
  5. click browser back button
  6. Notice duplicate breadcrumb item

image

SgtPooki commented 1 year ago

seems to be related to https://github.com/pln-planning-tools/Starmap/blob/f598b420601b9ae078040bc0833468d28ebc6ade/components/roadmap/NewRoadmap.tsx#L70