search

plnice / can-i-drop-jetifier

Gradle plugin that checks if there are dependencies using support library instead of AndroidX.
Apache License 2.0
558 stars 14 forks source link

Dependency substitution on support library causes plugin to say jetifer is fine to be dropped #11

Open Firestar99 opened 5 years ago

Firestar99 commented 5 years ago

We were using some dependency substitution on the support libraries in our app causing the plugin to tell us that we were fine dropping jetifier, even though we weren't. Removing the now unnecessary dependency substitution produced the expected results. Wanted to post this here as others may run into the issue too.

Example for dependency substitution:

    project.configurations.all {
        resolutionStrategy.eachDependency { details ->
            if (details.requested.group == 'com.android.support') {
                details.useVersion someVersion
            }
        }
    }
plnice commented 5 years ago

Hi, can you share some more details on why and how you use the dependency substitution - on which libraries, which versions etc.? Possibly create a clean project that reproduces the issue? Thanks!