search

plnkr / feedback

Feedback on Plunker
19 stars 11 forks source link

in embeds, the preview window shows a warning, and it is impossible to proceed or dismiss #602

Closed ksdavidc closed 10 months ago

ksdavidc commented 10 months ago

Describe the bug the preview window shows a warning, and it is impossible to proceed or dismiss

To Reproduce Steps to reproduce the behavior:

  1. Go to a page with a plunk, e.g. https://ggoodman.gitbooks.io/plunker/content/embed.html. I cite this example because it is your own page, but it isn'T working on a page I host either. In fact, no embeded plunks seem to work, but htey worked a while ago.
  2. cllick or proceed or dismiss in the plunk
  3. See error

Errors / logs in developer tools no errors noticed in developer tools

Expected behavior the result to show

Screenshots If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

Additional context I noticed some similar issues taht are several years old, so I am trying again.

ggoodman commented 10 months ago

It seems like there was a change in browser handling of cross-site cookies or something else that triggered this. I've updated the run server to issue SameSite=None to support this.

ksdavidc commented 10 months ago

Awesome. Working here.